Add plotting notebook and web scrape test #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! Based on our conversation, I think it might be good to change your web-scraping notebook to a .py file so that it can be better integrated with the others' code. |
arjunsavel
suggested changes
Apr 29, 2020
Filters the existing TESS data to find all TOI's that have an insolation flux comparable to that of the earth's. It also applies a boundary condition of 0.5-2.5 earth radii in order to also ensure said TOI's are more than likely terrestrial.
|
Looks nice! Last thing to do with this bit is to solidify the HZ boundaries based on Hsu et al. 2020. |
Shows different lists of potentially habitable planets using different types of parameters including insolation flux and parameters as defined by Zink and Hansen (2019) and Hsu et al (2020).
arjunsavel
reviewed
Jun 9, 2020
arjunsavel
left a comment
arjunsavel
left a comment
There was a problem hiding this comment.
Thanks for making the update! One more thing — I think you might've used P_Rad to cut on the exofop table for the Zink + Hansen criterion (beginning line 27) before defining P_Rad (line 30). Other than that, looks good to me!
Made some corrections to the file where variables such as P_rad were being used before they defined
This file computes TOI RV semi-amplitudes and plots them on a histogram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some plots I made using the data from TESS, in addition to some code that can download the csv from the exofop website.